Add Rake task to validate complete recurring configuration#740
Closed
J-Verz wants to merge 4 commits into
Closed
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is my attempt at a solution for the problems described in #722. It adds a Rake task
validate_recurring_configwhich loads the recurring task configuration (not only for the current RAILS_ENV) and asserts whether every task definition is valid. If any task is invalid, it exits with a non-zero code and prints the validation errors to stdout. If all tasks are valid, it prints 'All recurring tasks are valid' and exits with code 0.One problem it still has is that it only works for configurations split by Rails environment; if you define tasks in the top-level (like
recurring_with_invalid.ymlin the dummy app), you get an exception. I'm open for suggestions how to fix that.There are also no tests yet, let me know if you would like me to add those.